Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new keystore-path input parameter to allow customization of the keystore file location within Android projects. Previously, the keystore was hardcoded to release.keystore in the app directory.
Key changes:
- Added configurable keystore path parameter with a default value of
release.keystore - Updated keystore operations to use the configurable path instead of hardcoded values
- Added proper directory creation and error handling for custom keystore locations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| action.yml | Added keystore-path input parameter and updated keystore handling logic to use configurable paths |
| README.md | Updated documentation to include the new keystore-path parameter in usage examples and inputs table |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
README.md
Outdated
| | `keystore-store-password` | Keystore store password | No | - | | ||
| | `keystore-key-alias` | Keystore key alias | No | - | | ||
| | `keystore-key-password` | Keystore key password | No | - | | ||
| | `keystore-path` | Path for keystore | No | `release.keystore` | |
There was a problem hiding this comment.
The description 'Path for keystore' is unclear. It should specify that this is the path within the Android source directory where the keystore should be placed, matching the description in action.yml.
| | `keystore-path` | Path for keystore | No | `release.keystore` | | |
| | `keystore-path` | Path within the Android source directory where the keystore should be placed | No | `release.keystore` | |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
2 participants
Adding
keystore-pathparam for custom keystore locations